Remove one occurrence of the verb Toggle from Zoom out control. #65609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
l10n
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Closed
2 tasks
|
Size Change: -4 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Sep 24, 2024
|
Thanks for the improvement! |
|
Should this be backported to 6.7? It seems like an essential fix for Zoom Out and will benefit the string freeze stage. c.c. @getdave. |
I just asked for feedback on this in the #polyglots channel. |
|
@kevin940726 Apologies. I somehow missed this. Luckily we have @tellthemachines 🙇 Yes we should try to backport if possible. |
tellthemachines
added
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 21, 2024
Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: cfe6770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a part of #65491
What?
The verb 'Toggle' isn't well translatable in many languages and should be avoided. See #42492 and https://core.trac.wordpress.org/ticket/34753
Why?
See above.
How?
Removes the verb 'Toggle' from 'Toggle Zoom Out'.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast