Export useResizeObserver React Native version directly
#65588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
Does this PR need to be backported to the release branch? |
I'm not sure how this stuff works exactly, but at the very least, there should be no risk of users introducing code that would be made obsolete at a later date/release by this PR's changes. Any users trying to use the wrong (web-exclusive) API in a React Native context will instantly get an error. That said, I miss the context and knowledge to be able to answer that question will full confidence. |
…ix/use-resize-observer-react-native-export
…ix/use-resize-observer-react-native-export
|
Flaky tests detected in 1ea1b33. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11016529056
|
DaniGuardiola
deleted the
fix/use-resize-observer-react-native-export
branch
dcalhoun
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Following up to share that this change looks sound to me. 👍🏻
There are no errors in the native mobile app without this change currently, as we do not utilize the new callback variant, but it feels worthwhile to guard against this with the merged changes. If someone attempted to use the callback variant, it would result in the following error in the native mobile editor.
ERROR ReferenceError: Property 'ResizeObserver' doesn't exist
Thank you for merging this change! 🙇🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
useResizeObserverwas recently revamped (see #64943). There were some concerns about the React Native version potentially breaking, this PR addresses that.Why?
React Native users could potentially run into a bug if they tried to use the updated version of the utility, since it depends on web-exclusive APIs like
ResizeObserver.How?
Export legacy React Native version at the top-level, as discussed here: #65389 (comment)