Editor: Remove edit template menu item from block settings menu in blocks outside template. #65560
+13
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +7 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
This seems to break a lot of e2e tests 🤔. I didn't look deeply into the failures though, but I think it's worth investigating. |
|
Yep, I forgot a small condition, it should be fixed now. |
|
I think this breaks the fix in #62354. (c.c. @ramonjd). Now it shows an empty dropdown in the template editor:
Reproduction steps (I tested it in Playground):
|
|
Good catch, as I mentioned on the issue, I was not able to find a place where this menu was actually rendered :) I can restore it with the right fix 👍 |
|
It should be fixed now (both issues) |
youknowriad
changed the title
No problems! As a side note, I found git blaming on the lines intended to be removed is a good way to find the PR/issues responsible for the changes. That's how I found the PR and the reproduction steps too (Thanks to the detailed testing instructions). I can probably give it another review if nobody beats me to it. |
|
Flaky tests detected in 38326bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10991191541
|
jorgefilipecosta
approved these changes
Sep 23, 2024
t-hamano
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #60021
Follow-up to #65204
Closes #65548
What?
For template blocks, we shown an "edit template" menu in the block settings menu. To do that we check that the block is not within a "post" block. That said, we should limit this to "template-locked" rendering mode as otherwise the template is not even rendered.
In trunk, that menu is being incorrectly shown for any block.
Testing Instructions
1- Open the post editor
2- add a block and open the block settings menu
3- you shouldn't see the "edit template" menu item.
Also check these instructions #65560 (comment)