Post Navigation Link: Add block examples #65552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +90 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Sep 23, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Yeah 👍 I've added that in a972a13. I was wondering whether for some block variations if it made sense to render different examples in the Style Book. |
Oh yeah, good one. That might be a good thing to add to the backlog. I was just checking the button block in the style book. When you select it you're taken to the button global styles panel, where you can update the styles real-time. Would be neat to have that for variations as well. |
Do you mean block style variations? Unless I missed a change, block variations can't yet be styled via theme.json / global styles. My thinking for the display of a block variation within the Style Book was for users to find the block as they would within the inserter. So if they are used to adding a Next Page block rather than the Post Navigation Link, they'd see it labelled as such. Your point about the block type under Global Styles is well made though. There's probably not much benefit in aligning the Style Book examples with the inserter if the UI to style those blocks is under a different name. Still, it can all be refined when the heavy lifting iterating on the Style Book is done. |
Whatever these are: 
|
Ok, those are the block style variations a.k.a Block Styles 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #64707
Related: #65430
What?
Adds block example definitions for the Next/Previous variations of the Post Navigation Link block.
Why?
The Style Book is being iterated on and part of that effort is to ensure the desired blocks are shown there. Currently, this is dependent on blocks having an example defined.
How?
Adds examples to each block variation for the Post Navigation Link block.
Testing Instructions
Screenshots or screencast