-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command Palette: Fix "Add new page" command for hybrid theme #65534
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +28 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice follow up. Thanks for getting it up so quickly 🚀
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: b6229a4 |
Great catch, +1 thanks for fixing this quickly, Aki! 🙇 |
Follow up #65476
What?
The Pages screen in the site editor is not yet exposed to classic themes, so we need to link to the legacy URL.
a100344777e5a3a000b6260922be116d.mp4
How?
It links to the Pages part of the site editor only if it is a block theme and in the site editor.
At the same time, I wrapped
createPageEntity
inuseCallback
to remove the following warning:Testing Instructions
The "Add new page" command should link to the classic page screen.