Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataViews: remove unused .dataviews-view-table__cell-content-wrapper:empty style rule #65084

Merged
merged 2 commits into from
Sep 9, 2024
Merged

DataViews: remove unused .dataviews-view-table__cell-content-wrapper:empty style rule #65084

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5af0745
Make style rule count
oandregal Sep 5, 2024
69d76c4
Remove unused rule
oandregal Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/dataviews/src/dataviews-layouts/table/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@
display: flex;
align-items: center;
}
.dataviews-view-table__cell-content-wrapper:empty {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameskoster How should I test this is working properly? I couldn't do a proper git blame to understand where this rule comes from due to files being moved around, so I presume you'd know something about this :)

Copy link
Member Author

@oandregal oandregal Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that we're trying to ignore this cell from layout calculation. However, without this rule: its column's width is still going to be as wide as the table header; its row's height would use the tallest adjacent cell; and the related flex properties this overrides wouldn't be applied anyway? Struggling a bit to see when this would be important.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I don't exactly remember. I agree it doesn't seem to serve a purpose which suggest it relates to part of the UI that has evolved over time.

Since it hasn't been working for a while, and doesn't seem to affect anything maybe it's safe to remove?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it makes more sense. Pushed the removal.

display: none;
}

.components-v-stack > .dataviews-view-table__cell-content-wrapper:not(:first-child) {
min-height: 0;
Expand Down Expand Up @@ -171,10 +174,6 @@
}
}

.dataviews-view-table__cell-content-wrapper:empty {
display: none;
}

/* stylelint-disable-next-line scss/at-rule-no-unknown -- '@container' not globally permitted */
@container (max-width: 430px) {
.dataviews-view-table tr td:first-child,
Expand Down
Loading