Fix editor error in Safari due to availability of checkVisibility method #65069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
andrewserong
requested review from
youknowriad,
getdave,
ramonjd and
kevin940726
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +51 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
ramonjd
reviewed
Sep 4, 2024
ramonjd
approved these changes
Sep 4, 2024
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
|
Thanks for the quick reviews! 🙇 |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an editor error caused by #62711 in older versions of Safari that do not have support for
element.checkVisibility.Why?
Raised in https://github.com/WordPress/gutenberg/pull/62711/files#r1743668601, in older Safari versions the editor will error out when selecting a block as
checkVisibilityis not available.How?
Check that
element.checkVisibilityis available before calling it. If it's not available, then manually check the computed style's display, visibility, and opacity as in an earlier commit in #62711.Testing Instructions
trunkthe editor will error out. With this PR applied it shouldn't.Testing Instructions for Keyboard
Screenshots or screencast
Before
After