DataViews: add story about combining fields #64984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
Storybook
oandregal
commented
Sep 2, 2024
| const defaultLayouts = { | ||
| table: { | ||
| layout: { | ||
| combinedFields: [ |
There was a problem hiding this comment.
There's something wrong here that prevents the combined field from working properly:
Gravacao.do.ecra.2024-09-02.as.18.02.08.mov
cc @youknowriad @jorgefilipecosta in case you have thoughts.
|
Size Change: -92 B (-0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
@oandregal In the last commit, I updated the PR and did two things:
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
It's unfortunate that Github thinks these are completely different files, the changes were not that big. |
youknowriad
approved these changes
Sep 3, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Add story demonstrating how combining fields work.
Testing Instructions
npm install && npm storybook:dev