Fix: Pagination arrows are pointing in the wrong direction in RTL languages #64962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
force-pushed
the
pagination-arrow-rtl
branch
from
7655a9a to
4db1878
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
commented
Sep 1, 2024
| @@ -1,7 +1,7 @@ | |||
| /** | |||
| * WordPress dependencies | |||
| */ | |||
| import { __ } from '@wordpress/i18n'; | |||
| import { __, isRTL } from '@wordpress/i18n'; | |||
There was a problem hiding this comment.
The SetupToolbar component is imported by the BlockPatternSetup component. However, the BlockPatternSetup component itself does not seem to be used anywhere.
|
Size Change: +137 B (+0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
t-hamano
added
the
General Interface
cbravobernal
approved these changes
Sep 2, 2024
|
@cbravobernal Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64929
What?
This PR fixes the incorrect chevron icon direction in RTL languages.
Why?
In RTL languages, the horizontal document flow is reversed, so the chevron icon must also be displayed in reverse.
How?
chevronLeftandchevronRight. This keyword will find the following icons:chevronLeft,chevronLeftSmall,chevronRight,chevrontRightSmall.isRTL()function to reverse the direction.Testing Instructions
Screenshots or screencast
Grid Block Mover
Details
Navigation Block
DataViews Pagination
Note: You can also see that the text "PAGE 1 OF N" is not displayed correctly in RTL languages, but I'm not sure if this is an implementation issue or if it's not yet translated.
Font Library Modal
Edit Site Pagination Component (Revisions Pagination)
Note: You can also see that the text "1 OF N" is not displayed correctly in RTL languages, but I'm not sure if this is an implementation issue or if it's not yet translated.