-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Logo: Fix loader alignment issue #64919
Conversation
Size Change: +9 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Nice one! Seems safe to me, but if Ramon has a chance to look, would appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Before
2024-09-02.12.53.43.mp4
After
2024-09-02.12.53.02.mp4
@@ -654,16 +654,17 @@ export default function LogoEdit( { | |||
{ controls } | |||
{ mediaInspectorPanel } | |||
{ ( !! logoUrl || !! temporaryURL ) && logoImage } | |||
{ ! temporaryURL && ! logoUrl && ! canUserEdit && ( | |||
<Placeholder className="site-logo_placeholder"> | |||
{ ( !! isLoading || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think isLoading
would be a sufficient check as the value is already a boolean
<Placeholder className="site-logo_placeholder"> | ||
{ ( !! isLoading || | ||
( ! temporaryURL && ! logoUrl && ! canUserEdit ) ) && ( | ||
<Placeholder className="site-logo_placeholder" withIllustration> | ||
{ !! isLoading && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here if you feel like changing, but optional as it's already in trunk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the condition. Thanks @ramonjd. Ill merge the PR now.
What?
Spinner alignment was off in
Site Logo
block when image is set and we reload the screen.Testing Instructions
Site Logo
blockSite Logo
block, and Reload the pageScreenshots or screencast
|