Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataviews docs: Layout properties checks and link #64918

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

juanmaguitar
Copy link
Contributor

What?

Fixes checks in the table and add a link to the table so it can be referenced from other parts of the page

Why?

The table at https://developer.wordpress.org/block-editor/reference-guides/packages/packages-dataviews/#view-object doesn't show properly the checks.
Screenshot 2024-08-30 at 08 45 28
The information of this table is a great reference for other parts of the docs so a link to this part would be helpful.

@juanmaguitar juanmaguitar requested a review from oandregal August 30, 2024 06:47
Copy link

github-actions bot commented Aug 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanmaguitar juanmaguitar added [Type] Developer Documentation Documentation for developers [Package] DataViews /packages/dataviews labels Aug 30, 2024
- `children`: a list of field's `id` to combine
- `direction`: how should they be stacked, `vertically` or `horizontally`
- `children`: a list of field's `id` to combine
- `direction`: how should they be stacked, `vertically` or `horizontally`
Copy link
Member

@oandregal oandregal Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistyped this in the original docs PR, it should be:

Suggested change
- `direction`: how should they be stacked, `vertically` or `horizontally`
- `direction`: how should they be stacked, `vertical` or `horizontal`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepared a follow-up PR to fix this typo: #64973

Copy link
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I left a comment about direction values, which I had mistyped in the original PR.

@juanmaguitar juanmaguitar merged commit 7595597 into trunk Aug 30, 2024
68 of 70 checks passed
@juanmaguitar juanmaguitar deleted the layout-properties-link branch August 30, 2024 09:16
@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 30, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
* fix check icons

* defaultLayouts clarification and link to properties of layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] DataViews /packages/dataviews [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants