Fix grid layout padding on small screens #64878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Regression
|
Size Change: +4 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jasmussen
reviewed
Aug 29, 2024
| @@ -163,3 +163,11 @@ | |||
| .dataviews-view-grid__card.is-selected .dataviews-selection-checkbox { | |||
| top: $grid-unit-10; | |||
| } | |||
|
|
|||
| /* stylelint-disable-next-line scss/at-rule-no-unknown -- '@container' not globally permitted */ | |||
| @container (max-width: 430px) { | |||
There was a problem hiding this comment.
PR as a whole works for me. But this is new! I wonder:
- Should we have a system for these widths? Some variables we define and then use, just like we have modal preset sizes, so arbitrary fix-widths don't propogate?
- Do we need a fallback? Support is generally good, so probably not, but worth pondering.
There was a problem hiding this comment.
Potentially yes. Another approach would be to restructure the Page component a bit so that the behavior is built into the region that displays page content, with props to disable. That is a bigger discussion.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
approved these changes
Sep 13, 2024
noisysocks
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 23, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: a851bd2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the recent refactoring seems to have caused a regression in grid layout; the padding no longer adapts at certain breakpoints. This PR addresses that by moving the relevant styles to the appropriate file.
Testing Instructions