Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Hide deprecated __next36pxDefaultSize prop #64806

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Aug 26, 2024

Part of #46741

What?

Hides the deprecated __next36pxDefaultSize prop from the Storybook props tables.

Affected components

  • ComboboxControl
  • FormTokenField
  • InputControl
  • NumberControl
  • SelectControl
  • TreeSelect
  • UnitControl

Why?

These were still shown in the docs for a transitional period, given that we weren't throwing deprecation warnings to notify the switch to the 40px size prop. It's almost been a year since that switch, so I think we can clean them up.

How?

Hides the prop from the Storybook props tables using TSDoc @ignore, so TS compilation will continue to work.

Testing Instructions

Smoke test some changed Storybook pages.

@mirka mirka added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Aug 26, 2024
@mirka mirka self-assigned this Aug 26, 2024
@mirka mirka requested a review from ajitbohra as a code owner August 26, 2024 16:52
@mirka mirka requested a review from a team August 26, 2024 16:52
Copy link

github-actions bot commented Aug 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@mirka mirka merged commit 9c52776 into trunk Aug 27, 2024
68 of 70 checks passed
@mirka mirka deleted the storybook-hide-36px-prop branch August 27, 2024 09:17
@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 27, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
)

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants