Navigator: Replace deprecated NavigatorToParentButton with NavigatorBackButton #64775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
t-hamano
commented
Aug 24, 2024
Comment on lines
-22
to
-26
| style={ | ||
| // TODO: This style override is also used in ToolsPanelHeader. | ||
| // It should be supported out-of-the-box by Button. | ||
| { minWidth: 24, padding: 0 } | ||
| } |
There was a problem hiding this comment.
I read this comment and it now looks like we can do without this override.
t-hamano
commented
Aug 24, 2024
| return ( | ||
| <NavigatorToParentButton as={ GenericNavigationButton } { ...props } /> | ||
| ); | ||
| return <NavigatorBackButton as={ GenericNavigationButton } { ...props } />; |
There was a problem hiding this comment.
The NavigationBackButtonAsItem component doesn't seem to be used anywhere in Gutenberg.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -12 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Aug 24, 2024
|
Updated👍No need to update the changelog? |
ciampo
approved these changes
Aug 25, 2024
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…4775) * Navigator: Replace deprecated NavigatorToParentButton with NavigatorBackButton * Update storybook --- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR replaces
NavigatorToParentButton, which has been deprecated by #63317, withNavigatorBackButton.Why?
To suppress warnings in the browser console.
Testing Instructions
In this PR, l replaced the following components. Confirm that no browser console warnings are displayed and that the buttons are displayed correctly in each case.
Site Editor > Global Styles > Font Library > Library Tab > Select any font
Site Editor > Global Styles > Font Library > Install Fonts Tab > Select any font
Site Editor > Global Styles > Any child screen
Storybook