Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginSidebarMoreMenuItem: Update example, screenshot and description. #64761

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

ryanwelcher
Copy link
Contributor

What?

The PluginSidebarMoreMenuItem slot is a little redundant give that any PluginSidebar will create one automatically. This PR updates the example, description and screenshot to show how it could be used to override the default button text.

Part of: #64749

Copy link

github-actions bot commented Aug 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ryanwelcher <welcher@git.wordpress.org>
Co-authored-by: ndiego <ndiego@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ryanwelcher and others added 2 commits August 23, 2024 14:55
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Co-authored-by: Nick Diego <nick.diego@automattic.com>
@ryanwelcher ryanwelcher requested a review from ndiego August 23, 2024 18:56
Co-authored-by: Nick Diego <nick.diego@automattic.com>
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ryanwelcher ryanwelcher merged commit 5e90ab4 into trunk Aug 23, 2024
61 checks passed
@ryanwelcher ryanwelcher deleted the fix/plugin-sidebar-more-menu-item-docs branch August 23, 2024 19:40
@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 23, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
WordPress#64761)

* Update example, screenshot and description.

* Update docs/reference-guides/slotfills/plugin-sidebar-more-menu-item.md

Co-authored-by: Nick Diego <nick.diego@automattic.com>

* Update docs/reference-guides/slotfills/plugin-sidebar-more-menu-item.md

Co-authored-by: Nick Diego <nick.diego@automattic.com>

* Update docs/reference-guides/slotfills/plugin-sidebar-more-menu-item.md

Co-authored-by: Nick Diego <nick.diego@automattic.com>

---------

Co-authored-by: Nick Diego <nick.diego@automattic.com>

Co-authored-by: ryanwelcher <welcher@git.wordpress.org>
Co-authored-by: ndiego <ndiego@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants