Audio Block: Placeholder with illustration #64691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +122 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a462d07. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10493672619
|
|
Requested design feedback. I'm unsure if having the same placeholder design for all media blocks makes sense. |
|
Thanks for the PR! The discrepancy is, pending better ideas, actually intentional. In the case of featured image, site logo, and image, the gray material is meant to represent "this spot is reserved for a picture", as in the classic desktop publishing days where you'd draw a square the size of the desired image, with a diagonal line through it. There's less clearly a counterpart for audio, video, and cover blocks. We do need to improve the situation in very narrow containers, and for now every placeholder will get the gray material when small enough. Which is to say, there's still some room to expore details here. There are even ideas around showing the placeholder (an unconfigured block) even on the frontend. I think we need a clearer outlook on these pieces before we add the on-select behavior to blocks beyond Image, however. |
t-hamano
reviewed
Aug 24, 2024
…enhancement/audio-block-placeholder-state
|
@jasmussen placeholder was available on video block, so i thought it should be added to audio block too. 🙂 I have shared my thought here #44460 (comment) regarding placeholder design for different block. and I think this will be the component level change. |
|
A simple solution like this could work for all block, Except site logo block. Edit-Post-.Hello-world-.-.-gutenberg-.-WordPress.webm |
|
This PR is working fine.
I have concerns about this too. The Audio block only renders a long, skinny media player, not an image or video. I'm not sure if the placeholder with illustration is appropriate in the media player 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & Why?
When a block, such as video, image, or cover, is not selected, Gutenberg displays an illustrative image as a placeholder rather than a block controls. The illustration placeholder was presently missing from the audio block. The placeholder should be consistent across these blocks.
How?
Added placeholder with illustration on
Audioblock, When block is not selected.Testing Instructions
AudioblockScreenshots or screencast
Edit-Post-.two.-.-gutenberg-.-WordPress.webm