-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paste: fix image paste from Google Forms #64502
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @xpurichan. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -12 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
1acf5f9
to
12c73b4
Compare
12c73b4
to
3244f52
Compare
I've tested this - following the steps in the issue #60811 and can confirm that this PR fixed the reported issue! Thanks!! |
What?
Builds on the fix from #64479. When pasting from Google Forms, the image in pasted inline. This is happening because the raw HTML is an image wrapped an a
b
tag, and the image wasn't wrapped in a figure.Why?
Fixes #60811.
How?
Let's try to skip the body check and see if we get past integration failures. I don't see why we can't wrap any image that occurs outside of a p or div, in a figure element.
Testing Instructions
Create a Google form that generates a chart in the responses tab and copy that into GB.
Testing Instructions for Keyboard
Screenshots or screencast