Audio: Add border block support #64494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: +70 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Thanks for the PR!
I am concerned that when a thick border is applied, it will make the player less visible:
Is there any problem with applying a border to the block itself rather than the audio element?
Note: In the screenshot below, display:block has been applied to the audio element to prevent space from being displayed below the audio element.
However, I would like to hear the opinion of @aaronrobertshaw, who is knowledgeable about this initiative.
There was a problem hiding this comment.
Thanks for continuing these efforts @akasunil and the ping @t-hamano 👍
I am concerned that when a thick border is applied, it will make the player less visible:
Yeah, I agree. That doesn't look great in my opinion.
The current approach for applying border styles here conflicts with the application of padding on the wrapper as well. I think it only makes sense to apply them to the same location.
To be honest, I'm not even sure that padding should have been adopted on the audio block's wrapper. As it doesn't increase the size of the player at all, the best it could achieve visually is the same as margin (given no color support).
Applying padding and border to audio elements is pretty inconsistent/broken across browsers. I'm really not sure whether it's something we want to add if it can't be done consistently.
Here's the current state of this PR:
| Chrome | Safari | Firefox |
|---|---|---|
Screen.Recording.2024-09-27.at.11.10.58.am.mp4 |
Screen.Recording.2024-09-27.at.11.05.54.am.mp4 |
Screen.Recording.2024-09-27.at.11.06.50.am.mp4 |
It might be possible to achieve better results applying styling to various vendor prefixes to style the different browser audio players but I'm not convinced the complexity is worth it for what seems a very niche use case.
It might pay to get some design feedback on this one.
I can comment on that because I added it 😄 The main effect padding achieves is reducing the width of the player. Margin is the one that can potentially break layout in classic themes: try setting left/right margin on an Audio block in Twenty Twenty to see an instance of this. (I just realised it in testing right now, for some reason missed it on the original PR) If the effect we're after here is creating a frame for the player though, we could potentially achieve that with both border-radius and background color support, coupled with padding. For example: on the figure element. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Audioblock.Part of #43247
Why?
Audioblock is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Audioblock's border is configurable via Global StylesAudioblock and Apply the border stylesWatch attached video for more information.
Screenshots or screencast
Blog-Home-.-Template-.-gutenberg-.-Editor-.-WordPress.webm