Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in block-wrapper.md #64447

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix typo in block-wrapper.md #64447

merged 1 commit into from
Aug 13, 2024

Conversation

janpfeil
Copy link
Contributor

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Copy link

github-actions bot commented Aug 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @janpfeil.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: janpfeil.

Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: ndiego <ndiego@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @janpfeil! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 12, 2024
@fabiankaegy fabiankaegy added the [Type] Developer Documentation Documentation for developers label Aug 12, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :) Thanks for the fix!

Copy link
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janpfeil There are two additional instances in docs/reference-guides/filters/block-filters.md file, on lines 142 and 175. Could you please update those as well?

janpfeil added a commit to janpfeil/gutenberg that referenced this pull request Aug 12, 2024
ndiego pushed a commit that referenced this pull request Aug 12, 2024
@ndiego
Copy link
Member

ndiego commented Aug 12, 2024

@janpfeil There are two additional instances in docs/reference-guides/filters/block-filters.md file, on lines 142 and 175. Could you please update those as well?

@shail-mehta this has been fixed in #64452. Can you clear your change request on this PR, and then we can merge it. Thanks!

@ajitbohra ajitbohra enabled auto-merge (squash) August 13, 2024 16:36
@ajitbohra ajitbohra merged commit 5dae25b into WordPress:trunk Aug 13, 2024
67 of 72 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 13, 2024
getdave pushed a commit that referenced this pull request Aug 14, 2024
getdave pushed a commit that referenced this pull request Aug 14, 2024
peterwilsoncc pushed a commit to peterwilsoncc/gutenberg-build that referenced this pull request Sep 11, 2024
peterwilsoncc pushed a commit to peterwilsoncc/gutenberg-build that referenced this pull request Sep 12, 2024
peterwilsoncc pushed a commit to peterwilsoncc/gutenberg-build that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants