-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for some dynamically generated selectors in the core-data store #64269
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This is the first of a few PRs of this type. I wanted to get this merged to see how it looks in the docs and perhaps allow for some other contributors to take part in this effort. |
<!-- START TOKEN(Autogenerated selectors|../../../packages/core-data/src/selectors.ts) --> | ||
|
||
### canUser | ||
#### canUser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have been changed to an <h4>
(####
)? It appears to be a sub-heading for Selectors, which is an <h2>
, and the other sub-headings above are all <h3>
s.
Also, same question for the other sub-heading changes later. Otherwise, changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. That seems odd. Those were all generated by doc gen. Let me look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
What?
This PR manually adds documentation for the following dynamically generated selectors of the
core/data
store:getPostType
getPostTypes
getTaxonomy
getTaxonomies
Part of #64215
Why?
These are missed by the docgen tool and are much more user-friendly and docs are great :)