Background image: remove toolspanel placeholder component #64242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tire background image component set. The dummy tools panel was originally there to allow feature toggling, which hides and shows non-default toolspanel controls. However, now that the background panel is in a popover, space is not so much of an issue. Furthermore for now, background images and their properties can be treated as a control group.
ramonjd
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Aug 5, 2024
|
Size Change: -39 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 7, 2024
|
Thank you @andrewserong !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? How?
Part of:
This PR removes the dummy tools panel, and uses it to wrap the entire background image component set.
Context and more info: https://github.com/WordPress/gutenberg/pull/63216/files#r1701929926
Why?
The dummy tools panel was originally there to allow feature toggling, which hides and shows non-default
ToolsPanelcontrols.However, now that the background panel is in a popover, space is not so much of an issue.
Furthermore for now, background images and their properties can be treated as a control group.
Props to @mirka for calling it out.
Testing Instructions
There should be no regressions.
You should be able to reset all background image values using the ToolsPanel ellipsis menu RESET item.
Please check:
2024-08-05.11.57.18.mp4