Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid: Unset the rowStart and columnStart attributes when a block is removed from a manual layout #64186

Merged
merged 13 commits into from
Aug 6, 2024
Merged

Grid: Unset the rowStart and columnStart attributes when a block is removed from a manual layout #64186

merged 13 commits into from
Aug 6, 2024

Commits on Aug 5, 2024

  1. Unset the rowStart and columnStart attributes when a block is removed… 

    … from the grid
    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    2ad70df View commit details
    Browse the repository at this point in the history

  2. Follow the same logic as existing code for unsetting attributes when … 

    …switching to auto
    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5b35aa8 View commit details
    Browse the repository at this point in the history

  3. Add doc block

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    22796fa View commit details
    Browse the repository at this point in the history

  4. Unset the style.layout attribute when its empty

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    371c50e View commit details
    Browse the repository at this point in the history

  5. Also unset columnSpan and rowSpan

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    f0cce10 View commit details
    Browse the repository at this point in the history

  6. Keep span when switching grid types

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    fda307a View commit details
    Browse the repository at this point in the history

  7. Remove helper function in favour of setImmutably

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5463f2d View commit details
    Browse the repository at this point in the history

  8. Try supporting drag and drop from one grid to another

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    795a12b View commit details
    Browse the repository at this point in the history

  9. Do nothing when the new parent is a grid, it seems to work better by … 

    …leaving all attributes in place
    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    8cf4899 View commit details
    Browse the repository at this point in the history

  10. Use a mixture of destructuring and setImmutably

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    45554ab View commit details
    Browse the repository at this point in the history

  11. Only push attribute update when needed

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    0299cbf View commit details
    Browse the repository at this point in the history

  12. Fix potentially destructuring non-object

    @talldan
    talldan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b102b37 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Switch to for of loop

    @talldan
    talldan committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    5c8372e View commit details
    Browse the repository at this point in the history