Editor: Display empty option when post author is missing #64165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Aug 1, 2024
| currentAuthor = [ | ||
| { | ||
| value: 0, | ||
| label: '', |
There was a problem hiding this comment.
This matches how "Quick Edit" displays the missing author.
|
Size Change: +3.17 kB (+0.18%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Thanks for the PR! I have confirmed that this PR has resolved the issue. One thing that bothers me is that since there is no text on the toggle button, it is difficult for users to know that there is a button there. For example, what do you think about adding something like |
|
@t-hamano, I was also thinking about that. A better fallback might be more useful in both cases. @jameskoster, @jasmussen, what do you think? |
|
I'd tend to agree, and that "(No author)", parentheses included, can work. To note, we also have these cases:
The case is actually wrong there, I'll see if I can follow up. But the parentheses match this case:
That case should've probably been (No title) instead, however. |
|
Another argument in favor of "(No author)":
That said, shouldn't "(no title)" in that case be "(No title)"? |
|
Thanks, @jasmussen! I'm also considering using "(No author)" as a fallback in dropdowns. Do you think an empty option better conveys meaning there? Screenshot
|
|
My instinct is that (No author) works better than an empty field. |
Mamaduka
commented
Aug 2, 2024
| @@ -16,7 +17,8 @@ import { useAuthorsQuery } from './hook'; | |||
|
|
|||
| function PostAuthorToggle( { isOpen, onClick } ) { | |||
| const { postAuthor } = useAuthorsQuery(); | |||
| const authorName = postAuthor?.name || ''; | |||
| const authorName = | |||
| decodeEntities( postAuthor?.name ) || __( '(No author)' ); | |||
There was a problem hiding this comment.
Entity decoding is also needed here.
Screenshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #64163.
PR updates
useAuthorsQueryto include an empty option in the author list when a current post author is missing.Why?
It allows changing a missing post author when the dropdown only has one option (only one user remains on the site).
When
SelectControlorComboboxhas only one option and doesn't match the provided value, it will be automatically selected, and the user can't trigger a change event.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast
Dropdown
Combobox
