Centrally align entity in focused edit mode #64143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Regression
jameskoster
requested review from
youknowriad,
a team and
adamziel
and removed request for
a team
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
richtabor
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
It's a little different for headers in particular, if they're small. But that could also be because I'm so used to the pattern pinned to the top.
| Before | After |
|---|---|
With any content that's taller it feels much nicer—with the added benefit that the block toolbar is not covering the pattern (also the same improvement on smaller header patterns). That alone makes this really nice.
| Before | After |
|---|---|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
stokesman
reviewed
Jul 31, 2024
Comment on lines
+3
to
6
| display: flex; | ||
| background-color: $gray-300; | ||
|
|
||
| // Centralize the editor horizontally (flex-direction is column). |
There was a problem hiding this comment.
A belated note: changing display to flex was all that was needed thanks to the existing (though prior to this change ineffectual) align-items: center rule that is just below the comment. It would have been good to revise the comment since it’s incorrect. Also, personally, I think it’d have been nice to put the display: flex; and align-items: center; on adjacent lines.
|
Nice! I've been wanting to get to this state for a while :) |
|
Much nicer! |
|
This should also fix #62218 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When the entity is shorter than the container centrally align it on the canvas.
Why?
Helps communicate the isolated nature of the element and its detachment from any given page. The additional breathing room also improves the edit experience.
I believe this was a regression from a while ago that never got fixed.
How?
Apply
display: flexto.editor-visual-editor.Testing Instructions