Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: speak from device menu selection #64115

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

up1512001
Copy link
Member

Why?

Copy link

github-actions bot commented Jul 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: jeryj <jeryj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@jeryj jeryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting to this! I have one more recommended simplification.

packages/editor/src/components/preview-dropdown/index.js Outdated Show resolved Hide resolved
@up1512001 up1512001 requested a review from jeryj July 30, 2024 18:18
Copy link
Contributor

@jeryj jeryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thank you for this update!

@jeryj jeryj added the [Type] Code Quality Issues or PRs that relate to code quality label Jul 30, 2024
@jeryj jeryj enabled auto-merge (squash) July 30, 2024 19:04
@jeryj jeryj disabled auto-merge July 30, 2024 19:04
@jeryj jeryj enabled auto-merge (squash) July 30, 2024 19:05
@jeryj jeryj merged commit 060d4ca into WordPress:trunk Jul 30, 2024
64 of 65 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants