Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block categories based on categories proposed via the Style Book refresh Exploration #64080

Closed
wants to merge 2 commits into from

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Jul 30, 2024

What?

This PR reorganizes block categories according to the new order proposed as a part of the Style Book refresh exploration — Issue: #53431

Why?

These changes align the block categories more closely with their functions and expected usage patterns. This reorganization aims to enhance the overall user experience by making block discovery more intuitive within the site editor.

How?

  • Updated various block categories in the block JSON files.
  • Modified corresponding documentation to reflect these changes.

Testing Instructions

Testing Instructions for Keyboard

Copy link

github-actions bot commented Jul 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vcanales <vcanales@git.wordpress.org>
Co-authored-by: jffng <jffng@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@vcanales vcanales changed the title Update block categories Update block categories based on categories proposed via the Style Book refresh Exploration Jul 30, 2024
@vcanales vcanales added the [Type] Enhancement A suggestion for improvement. label Jul 30, 2024
@vcanales vcanales self-assigned this Jul 31, 2024
@@ -3,7 +3,7 @@
"apiVersion": 3,
"name": "core/post-date",
"title": "Date",
"category": "theme",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of these blocks have been switched from "theme" to "design" category, but from what I can tell from the issue, these blocks are in a subcategory within "theme".

Screenshot 2024-07-31 at 12 21 55 PM

Am I looking at the wrong reference for what the categories should be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you're right. I misread the doc and renamed the theme category; undone as of the latest commit.
I'm still wondering what the best way is to introduce the concept of a subcategory. In the discussion, I raised the idea of using the keyword attribute, but I'm not sold yet.

@vcanales vcanales force-pushed the update-block-categories branch from a7c6563 to b42d254 Compare July 31, 2024 18:24
@vcanales
Copy link
Member Author

Superseded by #65430

@vcanales vcanales closed this Sep 20, 2024
@vcanales vcanales deleted the update-block-categories branch September 20, 2024 04:31
@ramonjd
Copy link
Member

ramonjd commented Sep 20, 2024

Just saw this, thanks for starting it off.

I was thinking something similar, but wasn't sure if changing block.json categories would be a breaking change. For example, if themes sorting core blocks by categories are expecting blocks to be in those categories. Might be an edge case.

Creating a static list like #65430 does defer that decision at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants