Style Book: Fix critical error when heading block is not registered #64047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
commented
Jul 29, 2024
Comment on lines
+160
to
+169
| blocks: [ 1, 2, 3, 4, 5, 6 ].map( ( level ) => { | ||
| return createBlock( 'core/heading', { | ||
| content: sprintf( | ||
| // translators: %d: heading level e.g: "1", "2", "3" | ||
| __( 'Heading %d' ), | ||
| level | ||
| ), | ||
| level, | ||
| } ); | ||
| } ), |
There was a problem hiding this comment.
This is not directly related to this PR, but it is a code refactoring. The translator comment is the same as that of the HeadingLevelDropdown component:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this while reviewing #64038
What?
This PR fixes a critical error in the Style Book screen when the heading block is not registered.
Why?
This is because a non-existent block is being created via
createBlock().How?
Use the
getBlockType()selector to pre-check if a heading block exists, and if not, return non-heading block examples.Testing Instructions
wp.blocks.unregisterBlockType('core/heading')