-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Conditionally shows the description field in Template Grid layout #64043
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thank you, this seems to be working for me :) |
Unfortunately, this is not the right fix, this hard codes field ids within the generic DataViews component. I actually don't think there's an easy fix here. Maybe using CSS |
…eld separately using CSS
@youknowriad Thank you for your review. Could you please check it again? I have applied CSS to fix the issue. |
Size Change: +2.01 kB (+0.11%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
This works for me. Can you confirm it's still ok for you @jameskoster |
Yup, this fixes the issue :) |
@@ -71,6 +71,14 @@ | |||
align-items: flex-start; | |||
min-height: $grid-unit-30; | |||
|
|||
&:has(.dataviews-view-grid__field-value:not(:empty)) { | |||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? It doesn't seem to get applied, and I noticed no difference after commenting it out to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I see. However, display: flex
is already applied by the containing Flex
component, so redeclaring it here doesn't seem to serve a purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I have removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution :)
What?
Fixes: #63943
Why?
In Grid layout the template description field renders when empty, which isn't making sense.
How?
Conditionally shows the description.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-07-29.at.12.30.22.PM.mov