-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Block Lightbox: Fix warning error when resizing #63995
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
That one is better, as |
Size Change: -1 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
@luisherranz Thanks for the review! Updated 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Discovered while testing #62906
What?
This PR fixes a browser warning error that occurs when changing the browser width when the lightbox is not yet open:
Why?
From what I understand, when the lightbox is not open,
state.currentImage
is undefined.How?
Use optional chaining.
Alternatively, since overlay style calculations should not be necessary when the lightbox is not open and should be recalculated when the lightbox is opened, the following approach also works:
Testing Instructions