Make Distraction Free not conditional on viewport width #63949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +17 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a64c5ab. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10097669944
|
|
Good motivation, I'm here for this I may be testing this wrong, however, or my env. is acting up. I'm not seeing a difference between this branch and trunk:
|
Looks your environment isn't 100%. The editor should still have traits of distraction free, like no hover outlines and the same header controls removed from the header on desktop. |
jasmussen
approved these changes
Aug 1, 2024
Mamaduka
reviewed
Aug 1, 2024
richtabor
force-pushed
the
fix/distraction-free-mobile
branch
from
6ef5393 to
2377413
Compare
Mamaduka
approved these changes
Aug 9, 2024
richtabor
force-pushed
the
fix/distraction-free-mobile
branch
from
2377413 to
3de3c00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #63948 by:
Why?
You can end up in odd experiences where Distraction Free is conditionally affecting some UI, but not everything, everywhere, like detailed in #63948.
How?
Testing Instructions
Screenshots or screencast