-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template preview dimensions in table layout #63938
Conversation
Size Change: +6 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
@youknowriad @ntsekouras @oandregal when you have a moment could I get a review here? 🙏 |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@@ -37,6 +37,8 @@ | |||
&.is-viewtype-table { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still have these classes? I don't think they exist anymore no? you might want to rebase and adapt your code.
Oh yes, that was changed in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure what to test, but the changes are reasonable.
In table layout template previews are now smaller than they are on trunk. |
Fixes a regression that snuck in somewhere along the way.
What?
Reduce the size of the template preview in table layout.
Why?
It is currently much too large.
How?
width
property topage-templates-preview-field.is-viewtype-table
max-height
to avoid rows growing too large.Testing Instructions