Footnotes: only replace attribute if footnotes were detected #63935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +11 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
I didn't test but the changes make sense to me |
|
Maybe I should add an e2e test with a test block using PlainText |
ellatrix
force-pushed
the
fix/footnotes-replacement
branch
from
2611959 to
6a29997
Compare
ellatrix
force-pushed
the
fix/footnotes-replacement
branch
from
d03871b to
6a29997
Compare
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…ss#63935) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: sgomes <sergiomdgomes@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently the function
updateFootnotesFromMeta(which updates footnotes order when block order changes) seems to always update the block attribute if it's a string or RichTextData instance, even if no footnotes were detected. This is causing some issues with blocks that plain text string with new lines, which RichText will read as line break, and then serialise the line breaks in HTML. To prevent this, we can check if footnotes were detected at all.An alternative fix is to stop processing string attributes, and only process RichTextData attributes. Footnotes were added before we had this new data type, at the time rich text attributes were also plain strings. But I think some more work is needed to guarantee that rich text attributes are always RichTextData instances.
Why?
How?
Testing Instructions
Install this plugin: https://wordpress.org/plugins/syntaxhighlighter/
Add this in the code editor:
Now switch back to visual and add a footnote to the paragraph. The line breaks in the code block should not be converted to BR elements.
Testing Instructions for Keyboard
Screenshots or screencast