-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: Fix flaky e2e tests #63904
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix 👍
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
What?
Fixes #62862.
Fixes #63074.
Fixes #63122.
Fixes #63489.
PR fixes flaky Font Library e2e tests by adding context to the locator. I've also updated the method for accessing the site editor. This improved test performance by 5-10 seconds when running locally.
Why?
The
getByRole( 'button', { name: 'Styles' } )
locator was matching multiple elements from time to time.Testing Instructions