Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: use site locale in editor iframe #63883

Draft
wants to merge 13 commits into
base: trunk
Choose a base branch
from
Draft

Editor: use site locale in editor iframe #63883

wants to merge 13 commits into from

Commits on Sep 16, 2024

  1. First commit: testing passing locale to block editor settings.

    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d1dc06b View commit details
    Browse the repository at this point in the history

  2. Lint and force 'ltr'

    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3836f71 View commit details
    Browse the repository at this point in the history

  3. Adding WP's rtl to the body tag 

    Tentatively adding a rule to ensure that block placeholders, which are part of the editor UI, conform to the directionality of the user locale
    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ede0ade View commit details
    Browse the repository at this point in the history

  4. Add e2e tests

    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bf353d8 View commit details
    Browse the repository at this point in the history

  5. Move settings filter to compat/6.7

    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f2ed832 View commit details
    Browse the repository at this point in the history

  6. Remove user locale and use current locale

    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fd10caa View commit details
    Browse the repository at this point in the history

  7. Making things backwards compatible by defaulting to ownerdocument att… 

    …ributes.
    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3ea1c01 View commit details
    Browse the repository at this point in the history

  8. Removed placeholder rule. Notes: 

    Block placeholders are "technically" part of the editor UI, and should therefore match the editor UI's directionality.
! A better approach might be to create a HOC wrapping Placeholder in @wordpress/block-editor that sets the directionality and lang of the Placeholder component
    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e24e4c9 View commit details
    Browse the repository at this point in the history

  9. Remove is_locale_switched() check and update comment to reflect inten… 

    …ted property
    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5358a35 View commit details
    Browse the repository at this point in the history

  10. Sending language and rtl through from the site index REST response. 

    Passing locale data down to the iframe from the editor package instead of through the block settings.
    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1410000 View commit details
    Browse the repository at this point in the history

  11. Removing block editor settings test for now.

    @ramonjd
    ramonjd committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4bc2ad8 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Removed unused arg

    @ramonjd
    ramonjd committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a309123 View commit details
    Browse the repository at this point in the history

  2. LINTY

    @ramonjd
    ramonjd committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3a92868 View commit details
    Browse the repository at this point in the history