Tag Cloud: Improve state of block with no tags #63774
Conversation
akasunil
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -30,7 +30,7 @@ function render_block_core_tag_cloud( $attributes ) { | |||
| $tag_cloud = wp_tag_cloud( $args ); | |||
|
|
|||
| if ( ! $tag_cloud ) { | |||
| $tag_cloud = __( 'There’s no content to show here yet.' ); | |||
| return ''; | |||
There was a problem hiding this comment.
This is the server-side rendered block. Returning an empty string will also render nothing in the editor. The linked issue only states that it should render nothing on the front-end.
| @@ -29,8 +29,13 @@ function render_block_core_tag_cloud( $attributes ) { | |||
| ); | |||
| $tag_cloud = wp_tag_cloud( $args ); | |||
|
|
|||
| if ( ! $tag_cloud ) { | |||
There was a problem hiding this comment.
What's the reason for chaining ! to empty?
There was a problem hiding this comment.
Makes code more readable in my opinion. Do you need me to revert it to avoid unnecessary changes?
…enhancement/63684-improve-state-of-tag-cloud
| // Display placeholder content when there are no tags only in editor. | ||
| if ( ( defined( 'REST_REQUEST' ) && REST_REQUEST ) || is_admin() ) { | ||
| $tag_cloud = __( 'There’s no content to show here yet.' ); | ||
| } else { |
There was a problem hiding this comment.
WP introduced the wp_is_serving_rest_request method, which we could use here. The is_admin check shouldn't be required.
There was a problem hiding this comment.
Thank your for a review. I have addressed your feedback.
…enhancement/63684-improve-state-of-tag-cloud
* Render nothing when no tags are available in tag cloud block * Added condition to display placeholder in editor * Fix phpcs errors * Use wp_is_serving_rest_request function for conditional check Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
What?
Part of #63684
Why?
Tag cloud block render message in frontend when there are no tags available to display.
How?
Render nothing when no tags are available to display.
Testing Instructions
Screenshots or screencast