Fix: DataViews: Layout resets for patterns each time a new pattern category is selected. #63711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegory is selected.
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
requested review from
a team,
Mamaduka and
michalczaplinski
and removed request for
a team
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Jul 18, 2024
Mamaduka
added
the
[Feature] DataViews
Mamaduka
reviewed
Jul 18, 2024
| } | ||
| }, [ categoryId, previousCategoryId ] ); | ||
| }, [ categoryId, previousCategoryId, view ] ); |
There was a problem hiding this comment.
Passing the same state as a dependency as the effect updates could easily lead to infinite loops, especially when this state is an object. Only having a category check prevents that here.
Let's use the state updater function instead - setView( ( prevView ) => ( { ...prevView, page: 1 } ) );.
aaronrobertshaw
approved these changes
Jul 19, 2024
Mamaduka
deleted the
fix/DataViews-Layout-resets-for-patterns-each-time-a-new-pattern-category-is-selected
branch
|
Thank you for helping this PR get merged @Mamaduka, @aaronrobertshaw, and @jameskoster ! |
|
Does this need to be backported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63393
We were forcing the grid layout each time a pattern category was changed, and all the other defaults. This PR fixes the issue by keeping the previous view, and just resetting the page to 1 as the comment there indicated.
Testing Instructions
Go to the patterns page.
Switch to the table layout, change the pattern category, and verify that the table layout is active.