-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote: Add border support #63544
Quote: Add border support #63544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
It seems that when text alignment (center or right) is applied to this block, the theme style overrides the block-instance border, so the intended border is not applied. Do we need to reduce the CSS specificity of my theme style? Below is a screenshot from Emptytheme: |
Thanks for flagging that @t-hamano, I'll get a fix up for the theme styles shortly. |
A quick fix for the theme alignment styles and plain block style is up in #64045. |
Part of: #43241
What?
Adopts border support for the Quote block.
Why?
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-07-15.at.1.00.24.PM.mp4