Block Switcher Preview: Adjust the position and enable pattern list preview in mobile viewport #63512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w in mobile viewport
t-hamano
force-pushed
the
fix/block-preview-popover-position
branch
from
cef6fd1 to
cac4e19
Compare
|
Size Change: -196 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @albanyacademy. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
commented
Jul 13, 2024
| <div className="block-editor-block-switcher__popover-preview-container"> | ||
| <Popover | ||
| className="block-editor-block-switcher__popover-preview" | ||
| placement={ isMobile ? 'bottom' : 'right-start' } |
There was a problem hiding this comment.
For mobile layouts only, displays the pattern preview popover at the bottom.
ntsekouras
approved these changes
Jul 16, 2024
|
@ntsekouras Thanks for the review! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…w in mobile viewport (WordPress#63512) Unlinked contributors: albanyacademy. Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
|
@albanyacademy mind sharing your WordPress.org username so I can ensure its included in the 6.7 credits listing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51309
What?
This PR solves two problems:
Why?
Preview is not positioned correctly on narrow browser width
The
Popovercomponent hasflipprop to flip the popover when there isn't enough space by default. But the anchor element is a "point" and is fixed to the top right of the switcher popover:As a result, the preview popover will flip based on this anchor and overlap the switcher popover if there is not enough space to the right.
Pattern preview is not displayed in the mobile viewport, so conversion to pattern is not possible
On mobile viewports, the preview popover is hidden via CSS, so clicking "Patterns" from the switcher popover does nothing.
If we're transforming blocks, we don't necessarily need the preview popover, but for patterns, we need the preview popover because we need to select any pattern from the pattern list.
How?
Preview is not positioned correctly on narrow browser width
Position the preview popover's anchor so that it's equal in size and position to the switcher popover:
This will position the preview popover to the left of the switcher popover if there's not enough space to the right.
Pattern preview is not displayed in the mobile viewport, so conversion to pattern is not possible
On mobile viewports, there isn't enough space to display the preview popover on either the left or right side. As a workaround, place the preview popover below the switcher popover:
Testing Instructions
Screenshots or screencast
1e2a79a1d65644c05b14536697649a04.mp4