Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MediaUpload button for site logo from "Add media" to "Choose logo" #63498

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Update MediaUpload button for site logo from "Add media" to "Choose logo" #63498

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8fe17b
Add media -> Add Site Logo
richtabor Jul 12, 2024
f21f7c4
Add -> Choose
richtabor Jul 12, 2024
2d3c055
update MediaPlaceholder label and tooltipPosition
richtabor Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/block-library/src/site-logo/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,8 +590,6 @@ export default function LogoEdit( {

const blockProps = useBlockProps( { className: classes } );

const label = __( 'Add a site logo' );

const mediaInspectorPanel = ( canUserEdit || logoUrl ) && (
<InspectorControls>
<PanelBody title={ __( 'Media' ) }>
Expand Down Expand Up @@ -631,7 +629,7 @@ export default function LogoEdit( {
{ isLoading ? (
<Spinner />
) : (
__( 'Add media' )
__( 'Choose logo' )
) }
</Button>
<DropZone onFilesDrop={ onFilesDrop } />
Expand Down Expand Up @@ -671,9 +669,9 @@ export default function LogoEdit( {
<Button
icon={ upload }
variant="primary"
label={ label }
label={ __( 'Choose logo' ) }
showTooltip
tooltipPosition="top center"
tooltipPosition="bottom center"
onClick={ () => {
open();
} }
Expand Down
Loading