Templates DataViews: Set the right context for the preview field #63488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
commented
Jul 12, 2024
| @@ -176,7 +177,7 @@ function Preview( { item, viewType } ) { | |||
| // the block editor settings are needed in context where we don't have the block editor. | |||
| // Explore how we can solve this in a better way. | |||
| return ( | |||
| <ExperimentalBlockEditorProvider settings={ settings }> | |||
| <EditorProvider post={ item } settings={ settings }> | |||
There was a problem hiding this comment.
This Preview component should actually be moved to the "editor" package and be named something like PostPreview or something. The purpose of that is to preview a given postType + postId tuple.
There was a problem hiding this comment.
You mean by having a lighter component than the actual EditorProvider, right? Do you think this change will affect performance for now, until we implement that component?
There was a problem hiding this comment.
No, I think the EditorProvider is fine. but instead of having all of this custom logic here in the site editor, this seems like an easy reusable component (preview of a post)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -4 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jul 15, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…dPress#63488) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59082
What?
Some core blocks are WP specific and require the "EditorProvider" (the core/editor store) context to work properly and render the right information.
One of these blocks is the QueryTitle block and this is fixed in this PR.
Testing Instructions
1- Create a "Tag Archive" template and use the Archive Title block in it.
2- In the data views, the block should show the right placeholder.