Revert "Pages: Trash view should default to table layout." #63481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 905b41d.
jorgefilipecosta
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -21 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8d2521c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9907592688
|
Mamaduka
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Thanks, @jorgefilipecosta!
I think the original PR didn't include new perf tests, which are currently failing - #63170.
You might have to merge this with failing Perf job, because code still exists on trunk.
jorgefilipecosta
deleted the
revert-63138-update/Pages-Trash-view-should-default-to-table-layout
branch
scruffian
pushed a commit
that referenced
this pull request
Jul 15, 2024
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…#63481) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
priethor
added
the
[Feature] DataViews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #63138
Although the CI passed on the PR it caused the CI to fail on the trunk. Debugging it seems the CI error on the performance test is legitimate. I'm going to revert the PR and address the issue separately.