Core Data: Resolve user capabilities when fetching an entity #63430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
requested review from
youknowriad,
jsnajdr,
ellatrix,
tyxla and
TimothyBJacobs
|
Size Change: +141 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jul 11, 2024
tyxla
reviewed
Jul 11, 2024
Mamaduka
force-pushed
the
try/resolve-user-caps-when-fetching-entity
branch
5 times, most recently
from
b6ac044
to
27b4b0d
Compare
Mamaduka
commented
Jul 15, 2024
Comment on lines
+295
to
+306
| { hasResolved && ( | ||
| <ReusableBlockControl | ||
| recordId={ ref } | ||
| canOverrideBlocks={ canOverrideBlocks } | ||
| hasContent={ !! content } | ||
| handleEditOriginal={ | ||
| onNavigateToEntityRecord | ||
| ? handleEditOriginal | ||
| : undefined | ||
| } | ||
| resetContent={ resetContent } | ||
| /> |
There was a problem hiding this comment.
Unrelated change showcases the benefits of this proposal. I am happy to extract it into a separate PR.
Requests before with four pattern blocks on canvas:
Requests after:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I think PR is in good shape for reviews and feedback. |
jsnajdr
reviewed
Jul 16, 2024
| @@ -165,8 +171,29 @@ export const getEntityRecord = | |||
| } | |||
| } | |||
|
|
|||
| const record = await apiFetch( { path } ); | |||
| dispatch.receiveEntityRecords( kind, name, record, query ); | |||
| const response = await apiFetch( { path, parse: false } ); | |||
There was a problem hiding this comment.
Setting parse: false will disable the fetchAllMiddleware. See how it returns early when options.parse is false. Is this a concern here?
fetchAllMiddleware is relevant for fetching collections, and getEntityRecord fetches only one item, so it shouldn't be relevant. But what if I do:
getEntityRecord( 'postType', 'post', '', { per_page: -1 } );This will fetch the entire collection anyway, won't it? And should trigger fetchAllMiddleware.
There was a problem hiding this comment.
I also had similar concerns during the original discussion: #43480 (comment). But it shouldn't affect the getEntityRecord resolver.
The getEntityRecord supports only fetching a single entity. Any other usage is incorrect, and it's up to consumers to fix it.
Calling wp.data.select( 'core' ).getEntityRecord( 'postType', 'post', '', { per_page: -1 } ); will make a request, but then will return undefined.
tyxla
reviewed
Jul 16, 2024
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Mamaduka
force-pushed
the
try/resolve-user-caps-when-fetching-entity
branch
from
c38b9e3
to
c8ae4b6
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ss#63430) * Core Data: Resolve user capabilities when fetching an entity * Mark canUser selector as resolved * Fix unit tests * Dedupe logic * Showcase: Update Pattern block to benefit from new user permission resolutions * Clarify comment Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Inspired by #43480 (comment).
Hopefully, this will be more effective after merging #63415 and #63423.
PR updates the
getEntityRecordto resolve entity-related user permission when fetching entity data.Why?
Most of the time, actions to interact with the entity are displayed after loading it. Resolving user capability selectors for the same entity can improve the UI (no more popcorning) and reduce the number of requests the app makes.
Testing Instructions
Manually run selectors
canUserselector for the same entity shouldn't trigger a REST API request.Pattern blocks
OPTIONSrequests are made for these patterns. You can usev2/blocksto filter the endpoint.Testing Instructions for Keyboard
Same.
Screenshots or screencast
Requests before with four pattern blocks on canvas:
Requests after:
