-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Directory: Remove 'edit-post' package dependency #63349
Conversation
@@ -4,17 +4,14 @@ | |||
import { _n, sprintf } from '@wordpress/i18n'; | |||
import { useSelect } from '@wordpress/data'; | |||
import { blockDefault } from '@wordpress/icons'; | |||
import { PluginPrePublishPanel } from '@wordpress/editor'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref - #60628 (comment)
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -36 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import CompactList from '../../components/compact-list'; | ||
import { store as blockDirectoryStore } from '../../store'; | ||
|
||
// We shouldn't import the editor package directly | ||
// because it would include the wp-editor in all pages loading the block-directory script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other pages is this referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original comment referred to the wp-edit-post
package, accidentally loading it on other pages like Site Editor.
The context got lost somewhere in a string replacing. Full details can be found here - #45895.
Thanks, Ella! |
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
What?
This PR removes
@wordpress/edit-post
as a dependency from the block directory package. Component usage fromedit-post
was discouraged after #45895, and it was probably a leftover from the "great unification."I've also fixed the import for the
PluginPrePublishPanel
slot. The editor package is already used here.Testing Instructions
The feature has e2e test coverage.
Testing Instructions for Keyboard
Same.
Screenshots or screencast