Fix unlabeled Remove shadow buttons. #63197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -10 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jul 8, 2024
talldan
added
the
Backport to WP 6.7 Beta/RC
|
I've added the label for this to be backported for 6.6, as I believe this was introduced in 6.6, and is currently an issue in the RC. |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 8, 2024
Replace tooltip and ariaLabel with label to ensure that the "Remove shadow" button is labeled. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 3574f38 |
github-actions
bot
added
the
Backported to WP Core
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Replace tooltip and ariaLabel with label to ensure that the "Remove shadow" button is labeled. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #63196
What?
The 'Remove shadow' buttons are unlabeled.
They don't show a tooltip as well.
Why?
All interactive controls must be labeled.
Icon buttons must visually expose their accessible name via a tooltiip.
How?
Fixes the
labelprop.Removes incorrect
tooltipprop.Testing Instructions
arialabelortooltipHTML attributes.aria-labelattribute.Testing Instructions for Keyboard
Screenshots or screencast