DateFormatPicker: use CustomSelectControl V2 legacy adapter #63171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 tasks
|
Size Change: -52 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Package] Components
tyxla
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
LGTM 👍
FWIW the v2 legacy version without the extra item bottom margin looks better than the v1, which was a bit too spread out.
The v1 also keeps closing after a couple of tab changes while comparing to the v2 in a neighbor browser tab. The v2 does not do it, which I find convenient.
🚀
ciampo
deleted the
feat/custom-select-control-v2-adapter/date-format-picker
branch
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…s#63171) * DateFormatPicker: use CustomSelectControl V2 legacy adapter * Remove unnecessary styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #55023
Replace the V1
CustomSelectControlwith the V2 legacy adapter in the date format picker controlWhy?
The goal is to ultimately replace the legacy V1 implementation entirely with the V2 legacy adapter. We're performing the migration gradually, and fixing any bugs / gaps as we go.
How?
Testing Instructions
trunkNote: on trunk, each option item in the dropdown has a an extra
6pxbottom margin that is the result of a style leak (see the second set of screenshots below). I assume that's not intended. The leak does not apply when using the new version of the component since its option items are not rendered using theliHTML element.Screenshots or screencast
cscv2.date.format.picker.v1.mp4
cscv2.date.format.picker.v2.mp4