-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize focusable disabled ToolbarButton usage #63130
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ToolbarButton
s no longer need the special treatment! 👍
Thank you for the cleanup 🚀
Size Change: -33 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Follow-up to #63102
What?
Cleans up the code that was previously used to keep disabled
ToolbarButton
s focusable.Why?
ToolbarButtons will now always remain focusable when disabled (#63102).
Testing Instructions
Only the change in
packages/customize-widgets/src/components/header/index.js
is somewhat unpredictable. To test this, activate the Twenty Twenty-One theme and go to the Widgets editor. The disabled undo/redo buttons in the toolbar should behave as expected.