Dependency extraction: Map to regenerator-runtime instead of wp-polyfill
#63091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
|
This changes make sense to me. Should we backport this one into 6.6? |
youknowriad
approved these changes
Jul 3, 2024
|
Ya let‘s do that so its published earlier 👍 |
swissspidy
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 3, 2024
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: f66826e |
github-actions
bot
added
the
Backported to WP Core
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to https://core.trac.wordpress.org/ticket/60962 in WP 6.6, where
regenerator-runtimewas removed as a dependency fromwp-polyfill. Now it needs to be added explicitly if still needed.Why?
Via #63009 I realized that
@WordPress/dependency-extraction-webpack-pluginstill points towp-polyfillthough when using regenerator (which shouldn't happen when targeting newer browsers anyway).How?
Externalizes regenerator to
regenerator-runtimedirectly instead ofwp-polyfillTesting Instructions
If using generators in a script and targeting older browsers such as IE 11,
regenerator-runtimewould be added as a dependency instead ofwpo-polyfill.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A