Global Styles: Don't display browse styles unless the theme has full styles available #63083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -19 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
We should also resolve it here: |
scruffian
force-pushed
the
fix/browse-styles
branch
from
0d22ec6 to
fa7a474
Compare
|
Good catch. Fixed in fa7a474 |
|
Flaky tests detected in fa7a474. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9805784307
|
|
With the addition of #63173, I wonder if this is still necessary. Perhaps just removing the default style variation within will be fine instead.
|
|
I agree with @richtabor, per his scresnshot, because as a result of this PR, the entire Styles panel goes away:
|
|
Replaced by #63555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This removes the "Browse Styles" option from Global Styles when there are no full theme styles available.
Why?
Without this bug fix the browse styles area still appears but is empty.
How?
Create a new hook that gets all of the theme variations and then filters out the color and typography only variations.
Testing Instructions
Screenshots or screencast