Site Editor: patterns and templates cannot be edited from sidebar mobile view #63002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +6 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
andrewserong
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Thanks for looking into this! In general the links going deeper into page templates is working for me 👍
One issue I ran into, not sure if it's related, is that the W icon at the top left when attempting to go back from the edit view winds up crashing for me, with no error in the console:
2024-07-01.16.20.02.mp4
This doesn't happen for me when navigating up the hierarchy from editing a template. Only while editing a pattern. Can anyone reproduce that? Just wondering if it's something weird with my environment.
Not quite related to this bug, but one thing I found confusing at first with the mobile version of the dataviews screens is that there's no W icon, so I had to rely on browser back buttons to navigate up the hierarchy. This is challenging to do when we add in the ability to go to the edit view on mobile, as the back button might take us "back" to the editor if we've come from there, so it can be difficult to navigate up to the root of the site editor on mobile if we're going into the edit view.
Here's a quick demo:
2024-07-01.16.24.46.mp4
- Go to Templates screen
- Tap on a template to go to the edit view
- Tap on the W icon to go up a level
- There's no way to get out via tapping here, so use the browser back button
- We wind up back in the editor again
Just checking if it's only me, but I wasn't able to find template parts from the mobile view. When I go to Patterns, I can only see filters for the synced or not synced patterns, and there doesn't appear to be links for the template parts like there is on Desktop 🤔 
|
|
Thanks for testing @andrewserong 🙇🏻 So it sounds like the entire flow is broken for mobile. A bit of a shame, I was hoping for a quick win. I should know better 🤣 I'll dig a little more deeply this week to suss out where things fit together and see what's fixable. 🍺 |
I was able to reproduce this issue. The easiest way is to go to the Pages screen, open any editor canvas, and click the W logo.
I think there are still many issues with the mobile viewport. The main issue is probably #62878. It's a difficult question as to what extent this needs to be fixed in WP6.6 😅 |
Thanks for the thoughts @t-hamano After thinking about it for a nanosecond, I'll put this out there. For 6.6, users should at least be able to:
So I'll investigate the crash. With those things fixed hopefully we've restored base functionality. Any UX cluster bombs we can fix as follow ups. |
…irect the browser to the block editor in edit mode
ramonjd
force-pushed
the
fix/site-editor-dataviews-canvas-edit-mobile
branch
from
9d7f618 to
f247618
Compare
Forgot to reply to this, sorry. I don't see any filters for template parts on Desktop either. 
It looks like Template Parts are accessible also from the sidebar view, but in mobile view, this sidebar is not accessible so there's no way for users to list them. 😅 |
|
Flaky tests detected in f247618. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9753185727
|
…ome in mobile viewports. Turning it off as it appears more stable in local testing.
I think I've traced the crash to the use of Only firing that in desktop mode seems to have fixed the crashing for me, however I haven't located the root cause. Chrome supports |
This was referenced Jul 2, 2024
There's an issue for this: #62878 I hacked together something to address it in the short term, and have commented over there. 👍🏻 |
youknowriad
reviewed
Jul 2, 2024
|
Thanks for the reviews, folks! |
|
There was a conflict while trying to cherry-pick the commit to the wp/6.6 branch. Please resolve the conflict manually and create a PR to the wp/6.6 branch. PRs to wp/6.6 are similar to PRs to trunk, but you should base your PR on the wp/6.6 branch instead of trunk. |
ramonjd
added a commit
that referenced
this pull request
Jul 2, 2024
…ile view (#63002) * In mobile mode, check for canvas edit mode so the "Edit" callback redirect the browser to the block editor in edit mode * I suspect that the transition is causing intermittent crashing in Chrome in mobile viewports. Turning it off as it appears more stable in local testing. * Revert unintentional change Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: priethor <priethor@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org> Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org> Co-authored-by: mrfoxtalbot <mrfoxtalbot@git.wordpress.org>
|
Cherry-pick and merge to the wp/6.6 branch here: |
oandregal
added a commit
that referenced
this pull request
Jul 2, 2024
…ile view (#63002) (#63055) Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: priethor <priethor@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org> Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org> Co-authored-by: mrfoxtalbot <mrfoxtalbot@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
ellatrix
added
Backported to WP Core
|
I've prepared #63060 as a potential quick change for 6.6. |
arthur791004
pushed a commit
that referenced
this pull request
Jul 16, 2024
…ile view (#63002) * In mobile mode, check for canvas edit mode so the "Edit" callback redirect the browser to the block editor in edit mode * I suspect that the transition is causing intermittent crashing in Chrome in mobile viewports. Turning it off as it appears more stable in local testing. * Revert unintentional change Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: priethor <priethor@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org> Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org> Co-authored-by: mrfoxtalbot <mrfoxtalbot@git.wordpress.org>
Closed
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ile view (WordPress#63002) * In mobile mode, check for canvas edit mode so the "Edit" callback redirect the browser to the block editor in edit mode * I suspect that the transition is causing intermittent crashing in Chrome in mobile viewports. Turning it off as it appears more stable in local testing. * Revert unintentional change Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: priethor <priethor@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: ironprogrammer <ironprogrammer@git.wordpress.org> Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org> Co-authored-by: mrfoxtalbot <mrfoxtalbot@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #62932
Fixes #62649
Specifically, this PR addressing the following:
cc @oandregal to make sure everything from #60689 still works
Why?
So that clicking Edit on Templates and Patterns in the data views redirects the browser to the block editor in edit mode.
Also, to avoid crashing the browser.
How?
In the mobile area prop in the Site Editor router, check for
canvas === 'edit'and render the Editor component.Skip using
document.startViewTransitionin mobile view when switching canvas modes.Testing Instructions
782pxwide to trigger the mobile viewdocument.startViewTransitiondoesn't have full support outside Chrome.Testing Instructions for Keyboard
Screenshots or screencast
Before
2024-07-01.13.45.41.mp4
After
2024-07-01.14.02.54.mp4