DataViews: Register the deletePost action like any third-party action. #62913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The other similar PR #62647 got blocked because we need access to the store and we need isElligible to be reactive (which is hard to solve). So I'm trying another action that doesn't have these requirements in this PR. But the current PR is also blocked for two reasons:
|
sirreal
reviewed
Jun 27, 2024
|
Size Change: +188 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
The block editor uses this package in the browser. URL is available globally, there is no need to import it.
youknowriad
force-pushed
the
update/register-delete-action
branch
from
b917103
to
103d676
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
added
[Feature] Extensibility
|
This should be ready for review. |
youknowriad
commented
Jun 28, 2024
| @@ -91,6 +93,7 @@ export function initializeEditor( | |||
| enableFSEBlocks: settings.__unstableEnableFullSiteEditingBlocks, | |||
| } ); | |||
| } | |||
| registerDefaultActions(); | |||
There was a problem hiding this comment.
I couldn't find a better place to call this. I kind of maps what we do for blocks.
youknowriad
commented
Jun 28, 2024
| has_theme_file: boolean; | ||
| } | ||
|
|
||
| export type Post = TemplateOrTemplatePart | BasePost; |
There was a problem hiding this comment.
I like a lot that we could use the "actions" refactoring to slowly augment our "entities" types. In the long run, this will help a lot when build UI for entities.
jorgefilipecosta
approved these changes
Jul 1, 2024
| @@ -0,0 +1,11 @@ | |||
| diff --git a/node_modules/postcss-urlrebase/index.d.ts b/node_modules/postcss-urlrebase/index.d.ts | |||
There was a problem hiding this comment.
Why is this change required?
There was a problem hiding this comment.
Something about fixing the typescript types. But @sirreal would know more precisely.
There was a problem hiding this comment.
A browser package (editor, I believe) uses postcss in the browser.
This dependency expected to work in a node environment (most common for postcss stuff) and use the URL type imported from node. This is not available in the environment. However, it's fine to use the URL global, which is what this change does. Otherwise, the package would error when it tried to import a non-existent (node.js) type.
There was a problem hiding this comment.
Add package patch note here: #63015
ntsekouras
reviewed
Jul 1, 2024
| TEMPLATE_ORIGINS.custom | ||
| ) && | ||
| ! template.has_theme_file && | ||
| ! template?.has_theme_file |
There was a problem hiding this comment.
This is the same check now.. #63021
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
WordPress#62913) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #61084
Similar to #62647
What?
In #62052 an API to register and unregister dataviews actions has been implemented. But in order to allow third-party developers to be able to unregister these actions, we need to be using the same actions in Core to register the core actions.
The current PR explore the possibility to use the API to register one action: "delete post".
Testing Instructions
1- Open the patterns dataviews and try removing a user created pattern.
2- You should be able to see the "delete" action in the actions dropdown menu
3- you can try to use the action.